Enable http-crate feature while building docs
#755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ureq` properly adheres to the additive-only-ness of crate feature flags, allowing interop with the `http 0.2` and `http 1.x` crates concurrently. We should take advantage of this in the docs as well, by generating entries for `http 1.x` `impl`s (with appropriate autogenerated `Available on create feature http-crate only` markers) to make users aware of the bindings they have available. Also clean up the `http 1` integration a bit following the breaking changes that I proposed (for `http 0.2`) a long time ago, which seem to have been copy-pasted to the new `http 1` interop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ureqproperly adheres to the additive-only-ness of crate feature flags, allowing interop with thehttp 0.2andhttp 1.xcrates concurrently. We should take advantage of this in the docs as well, by generating entries forhttp 1.ximpls (with appropriate autogeneratedAvailable on create feature http-crate onlymarkers) to make users aware of the bindings they have available.Also clean up the
http 1integration a bit following the breaking changes that I proposed (forhttp 0.2) a long time ago, which seem to have been copy-pasted to the newhttp 1interop.