Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update uri to omit deployment ids for assistant and thread paths #431

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

CarterBland
Copy link

@CarterBland CarterBland commented Feb 15, 2024

Summary:
Solves Assistants Support for Azure's new API version 2024-02-15-preview #430

Tested in my own local application and the URI with the deployment id omitted unblocks the whole process from creating an assistant, thread, and message.

Solution:
Support assistants API by removing the deployment id for certain paths

Example:
https://custom-domain.openai.azure.com/openai/deployments/gpt-35-turbo/assistants
to
https://custom-domain.openai.azure.com/openai/assistants

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?

@CarterBland CarterBland marked this pull request as draft February 15, 2024 22:45
@CarterBland CarterBland marked this pull request as ready for review February 15, 2024 23:08
lib/openai/http.rb Outdated Show resolved Hide resolved
@CarterBland
Copy link
Author

@alexrudall Any status on this?

@alexrudall
Copy link
Owner

@alexrudall Any status on this?

Thanks for patience, I need to get access to Azure OpenAI so I can test this & other Azure PRs - hope to within next week or 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants