Fix [issue #5](#5) (slots items have a private access level by default)

alexprey · Aug 25, 2020 · 66e6b89 · 66e6b89
1 parent fc7ed7b
commit 66e6b89
Show file tree

Hide file tree

Showing 6 changed files with 36 additions and 323 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,10 @@ All notable changes to the "svelte-intellisense" extension will be documented in
 
 Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file.
 
+## [3.0.4] 25.08.2020
+
+- 🛠 **[Fixed]** Fix [issue #5](https://github.com/alexprey/sveltedoc-parser/issues/5) (slots items have a private access level by default)
+
 ## [3.0.3] 25.08.2020
 
 - 🛠 **[Fixed]** Fix [issue #28](https://github.com/alexprey/sveltedoc-parser/issues/28) (Inline event handlers in markup cause errors when used without quotes)

diff --git a/README.md b/README.md
@@ -7,6 +7,10 @@ Generate a JSON documentation for a Svelte file
 
 ## Changelog 
 
+### [3.0.4] 25.08.2020
+
+- 🛠 **[Fixed]** Fix [issue #5](https://github.com/alexprey/sveltedoc-parser/issues/5) (slots items have a private access level by default)
+
 ### [3.0.3] 25.08.2020
 
 - 🛠 **[Fixed]** Fix [issue #28](https://github.com/alexprey/sveltedoc-parser/issues/28) (Inline event handlers in markup cause errors when used without quotes)

diff --git a/lib/parser.js b/lib/parser.js
@@ -603,6 +603,7 @@ class Parser extends EventEmitter {
  if (this.features.includes('slots')) {
  const slot = {
  name: attrs.name || 'default',
+ visibility: 'public',
  description: lastComment
  };
 

diff --git a/package.json b/package.json
@@ -1,11 +1,12 @@
 {
  "name": "sveltedoc-parser",
- "version": "3.0.3",
+ "version": "3.0.4", 
  "description": "Generate a JSON documentation for a Svelte file",
  "main": "index.js",
  "scripts": {
  "lint": "eslint ./**/*.js",
  "test": "mocha ./test/**/*.spec.js",
+ "prepublish": "npm run test && npm run lint",
  "test:unit": "mocha ./test/unit/**/*.spec.js",
  "test:integration": "mocha ./test/**/integration/**/*.spec.js",
  "test:integration-overall": "mocha ./test/**/integration/overall/overall.main.spec.js",

diff --git a/test/svelte2/integration/overall/overall.main.doc.json b/test/svelte2/integration/overall/overall.main.doc.json
@@ -461,6 +461,7 @@
  "slots": [
  {
  "name": "default",
+ "visibility": "public",
  "description": null,
  "locations": [
  {
@@ -475,6 +476,7 @@
  },
  {
  "name": "footer",
+ "visibility": "public",
  "description": null,
  "locations": [
  {