Change test case methods to snake_case #169
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update naming convention to match official Laravel documentation. These best practices are currently out-of-step with modern Laravel standards. * Laravel [officially changed to snake_case](laravel/laravel#5574) for test case methods in version 8.0. * [Official Laravel documentation](https://laravel.com/docs/10.x/testing) uses snake_case. * [Laracast videos](https://laracasts.com/series/phpunit-testing-in-laravel/episodes/2) use snake_case. * The [previous discussion's](alexeymezenin#28) conclusions on this matter are no longer correct.
JohnnyWalkerDigital
referenced
this pull request
May 19, 2023
|
@alexeymezenin You seem to be engaging with this repo again... How about bringing it up to speed with current Laravel standards? |
|
Snake case should be used in tests regardless Laravel. It differs from regular methods and force developer to pay extreme attention to those. |
chrispmcgee
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update naming convention to match official Laravel documentation. (These "best practices" are currently out-of-step with modern Laravel standards.)
Reasoning: