Make arrow keys not scroll so slow you want to self-harm #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All keyboard and mouse button work via standard text editor semantics: keeping a button pressed will wait for a while, after which it will repeat at fixed rate. That's fine for a text editor or whatnot, but it's painful when you want to scroll with the arrow keys. I hated this back when I first played the game, and I'm hating it now. I don't think anyone will miss the old "functionality". We can't outright remove the delay for all keys, as e.g. pressing "i" will repeat so fast that you can never open the inventory. Come to think of it, I think we can remove all of this functionality, at least for the keyboard as I don't *think* it's ever used (it is used for mouse buttons, although that too can be simplified greatly) – but all of that is a much larger refactor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All keyboard and mouse button work via standard text editor semantics: keeping a button pressed will wait for a while, after which it will repeat at fixed rate.
That's fine for a text editor or whatnot, but it's painful when you want to scroll with the arrow keys. I hated this back when I first played the game, and I'm hating it now. I don't think anyone will miss the old "functionality".
We can't outright remove the delay for all keys, as e.g. pressing "i" will repeat so fast that you can never open the inventory. Come to think of it, I think we can remove all of this functionality, at least for the keyboard as I don't think it's ever used (it is used for mouse buttons, although that too can be simplified greatly) – but all of that is a much larger refactor.