Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use uppercase music file in main menu #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hughobrien
Copy link

As per the docs:

Music files themselves (with ACM extension) should be all uppercased, regardless of sound and music folders.

Running under strace shows ENOENT due to hardcoded lower-case

strace -e trace=open,openat fallout-ce

openat(AT_FDCWD, "data/sound/music/07desert.ACM", O_RDONLY) = -1 ENOENT (No such file or directory)

@avnik
Copy link

avnik commented May 6, 2024

@hughobrien may be better use compat_resolve_path in code playing music, instead change hardcoded casing?

@hughobrien
Copy link
Author

Agreed in principle, but that would likely be a refactor more than a bug fix. e.g. this pattern is used elsewhere in the file:

gsound_background_play_level_music("03WRLDMP", 12);

@hughobrien
Copy link
Author

@alexbatalov May I ask if this is a change you would consider merging or if you would prefer an alternative approach? Thank you for your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants