feat: parameter to add a space under the calendar #871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you use the
![Capture d’écran 2024-05-02 à 09 17 42](https://private-user-images.githubusercontent.com/33631420/327345497-e1cff665-349e-4fcb-ac45-f6993a336167.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzNTIzNDAsIm5iZiI6MTcxODM1MjA0MCwicGF0aCI6Ii8zMzYzMTQyMC8zMjczNDU0OTctZTFjZmY2NjUtMzQ5ZS00ZmNiLWFjNDUtZjY5OTNhMzM2MTY3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE0VDA4MDA0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQwNjdhZjFmM2I4YWRmZWU4NDEzMjdkNjBjN2I4NGNhMWQzYWE4MDQzZmU3NzAzMjJjMmVmN2EyMmFlM2NiZTImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.Gl2TysHoeOMpKu-Erzg2CHxpUrO7Z6Z2bmq4yiS4FrQ)
markerMargin
parameter in order to add some top margin, the rendering of the Marker can be cropped at the bottom of the Calendar.The proposed solution would be to increase the
![Capture d’écran 2024-05-02 à 09 17 54](https://private-user-images.githubusercontent.com/33631420/327346767-581133b9-5aa2-4a7e-b957-9979777a7688.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzNTIzNDAsIm5iZiI6MTcxODM1MjA0MCwicGF0aCI6Ii8zMzYzMTQyMC8zMjczNDY3NjctNTgxMTMzYjktNWFhMi00YTdlLWI5NTctOTk3OTc3N2E3Njg4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTQlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjE0VDA4MDA0MFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE0MjJiYzJhOWQzN2E0ODQyNTJlOWZlNGMzZTZkOTQ0MzYwNWM5ZDhkMzQ3Mjc3NTZjYWYxODg0ODNiNzc4YTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.WIjzm8Hd9FqHctdBkhQ8UUCIqAYdqHNjfJ9JNcfLNsw)
rowHeight
parameter in order to correctly handle the display of the markers. Sadly, this solution won't fit every needs.I ended up with the solution of adding a new parameter that I called
bottomSpace
(could have beenbottomMargin
, but I thought that this name was misleading) which job is to add some more space in theAnimatedContainer
rendering the Calendar, and thus allowing to correctly draw the Markers.There might be a sexier solution to this issue, but it'd ask a lot more work and brain juice, alongside with a lot more of refactoring. With this update, it won't break anything to the current users