Adopt NI coding style (mostly) #129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh no, oh no... merge conflicts. I have to wait until PR #128 goes in before resolving the current and known future conflicts. |
|
Oh! I missed reviewing this! |
|
Are these changes still relevant given the recent updates related to the new PR experience? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an NI project, this code should adopt the NI style guide for JS.
We still disable some rules, and the style guide is still in alpha, yet I plan to iterate on it as we get new versions and as I have time. My goal is to get to no rule disables or overrides, whether by conforming or proposing changes to the style guide.
Closes #116