Added keypoints support to RandomSizedBBoxSafeCrop. #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed misleading unused parameters from crop_keypoint_by_coords()
Also removed misleading unused parameters from crop_keypoint_by_coords() - Black fixes
Also removed misleading unused parameters from crop_keypoint_by_coords() -README
Dipet
reviewed
Sep 7, 2020
Dipet
added
Improvements needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added keypoints support to
RandomSizedBBoxSafeCrop.Also removed misleading unused parameters from
crop_keypoint_by_coords(...): it had the same signature ascrop_bbox_by_coords(...), butcrop_bbox_by_coordsscaled resulting bboxes to(crop_height, crop_width)whilecrop_keypoint_by_coordsdidn't, so parameterscrop_heightandcrop_widthwere not only excessive but misleading.