temp commit

[ternaus]

No description provided.

[sourcery-ai]

Hey @ternaus - I've reviewed your changes and they look great!

General suggestions:

• Consider revising the error message in apply_to_mask to accurately reflect the unsupported operation.
• Correct the typo in the dictionary key preprocessing_pipepline to preprocessing_pipeline to avoid potential runtime errors.
• Evaluate the added complexity due to conditional imports and the introduction of new methods for managing external parameters. Consider if there are simpler alternatives that achieve the same goals.

Here's what I looked at during the review

• 🟡 General issues: 2 issues found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Docstrings: all looks good

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

• X
• Mastodon
• LinkedIn
• Facebook

---

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

[sourcery-ai]

issue (typo): The apply_to_mask method in the Mosaic class raises NotImplementedError with a message indicating that Mosaic does not support keypoints, which seems to be a copy-paste error from the apply_to_keypoints method. The error message should correctly reflect that it's the mask processing that is not implemented.

Suggested change

	def apply_to_mask(self, mask: np.ndarray, mix_data: List[ReferenceImage], *args: Any, **params: Any) -> np.ndarray:
	msg = "Mosaic does not support keypoints yet"
	raise NotImplementedError(msg)
	def apply_to_mask(self, mask: np.ndarray, mix_data: List[ReferenceImage], *args: Any, **params: Any) -> np.ndarray:
	msg = "Mosaic does not support mask processing yet"
	raise NotImplementedError(msg)

[sourcery-ai]

issue (typo): There's a typo in the dictionary key preprocessing_pipepline; it should be preprocessing_pipeline. This typo could lead to runtime errors when accessing the returned dictionary values.

Suggested change

	return {"mix_data": sampled_reference_data, "preprocessing_pipepline": preprocessing_pipeline}
	return {"mix_data": sampled_reference_data, "preprocessing_pipeline": preprocessing_pipeline}

[sourcery-ai]

issue (complexity): The introduction of conditional imports for TYPE_CHECKING and the new update_with_external_params method increases the complexity of the class. The conditional imports, while a common pattern for type hints, add a conditional code path that's not executed at runtime, potentially making the code harder to follow for those unfamiliar with this pattern. Additionally, the update_with_external_params method, along with the management of external_bbox_params and external_keypoint_params, introduces more state into the class. This increases the complexity by adding more side effects and interactions to consider.

While these changes do introduce new functionality and flexibility, it's important to weigh the added complexity against the benefits. If the goal of these changes is to incorporate external parameters directly into the class, it might be challenging to simplify without compromising the new features. However, it's worth considering if there are alternative approaches that could achieve the same goals with less complexity, such as handling external parameters outside of the class to keep it focused on its primary responsibilities.