Support keypoint on ElasticTransform (2-D)
#1325
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ``apply_to_keypoint`` funtion to class ``ElasticTransform``. Only consider 2-D case.
Modified support for keypoints of ``ElasticTransform``. The previous version was incorrect. In fact, the coordinates of the transformed keypoints can only be obtained by transforming the target points into images followed by elastic transformation. However, the cost is long running time, especially if there are many keypoints.
Modified support for keypoints of ``ElasticTransform``. The previous version was incorrect. In fact, the coordinates of the transformed keypoints can only be obtained by transforming the target points into images followed by elastic transformation. However, the cost is long running time, especially if there are many keypoints.
Dipet
reviewed
Oct 26, 2022
Comment on lines
+275
to
+276
| interp_y, interp_x = np.where(remap_image == np.max(remap_image)) | ||
| return (interp_x[0], interp_y[0], 0.0, 0.0) |
There was a problem hiding this comment.
What if the keypoint outside of the image? Looks like we always will find keypoint inside the image and in the case when we can not see the keypoint
There was a problem hiding this comment.
Yes, there is such a problem, but I can't think of a simple and elegant way to solve it. Therefore, you should try to ensure that the keypoints do not go beyond the scope of the image, otherwise it will return incorrect results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite (Add)
apply_to_keypointfuntion on classElasticTransform. Only consider 2-D case.