Add gamma invert transform #1309
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dipet
requested changes
Oct 11, 2022
Comment on lines
+794
to
+795
| else: | ||
| img = 1 - np.power(1 - img, gamma) |
There was a problem hiding this comment.
I think better to take max value from MAX_VALUES_BY_DTYPE because img might have int32 dtype
| @@ -1371,6 +1371,8 @@ class RandomGamma(ImageOnlyTransform): | |||
| Args: | |||
| gamma_limit (float or (float, float)): If gamma_limit is a single float value, | |||
| the range will be (-gamma_limit, gamma_limit). Default: (80, 120). | |||
| p_invert (float): Probability of applying transform symmetrical to gamma transform with respect to the y=x. | |||
| Identical to sequentially applied InvertImg, RandomGamma and InvertImg. Default: 0.0. | |||
| return { | ||
| "gamma": random.uniform(self.gamma_limit[0], self.gamma_limit[1]) / 100.0, | ||
| "invert": random.random() > self.p_invert, | ||
| } | ||
|
|
||
| def get_transform_init_args_names(self): | ||
| return ("gamma_limit", "eps") |
There was a problem hiding this comment.
Please, add p_invert to get_transform_init_args_names
| return {"gamma": random.uniform(self.gamma_limit[0], self.gamma_limit[1]) / 100.0} | ||
| return { | ||
| "gamma": random.uniform(self.gamma_limit[0], self.gamma_limit[1]) / 100.0, | ||
| "invert": random.random() > self.p_invert, |
There was a problem hiding this comment.
Incorrect condition. Must be random.random() < self.p_invert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend RandomGamma transform with invert gamma, which is applied with p_invert probability.