Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store version in a separate module #271

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ritiek
Copy link

@ritiek ritiek commented Apr 19, 2021

This allows us to read version from setup.py before dependencies are installed.

Addresses #252.

@alastair
Copy link
Owner

Thanks for the recommendation. I'm a bit worried about using exec() in the setup file, perhaps it'd be better to use something like setuptools-scm or versioneer. Do you have experience with either of them? I've got experience with using setuptools-scm in some other projects, so I think that'd be a good choice. I believe that setuptools v42 (the version required for this feature) still supports python 2, so that'd be good to go for. While we should remove python 2 support soon, I'd like to do 1 more release supporting it first.

@ritiek
Copy link
Author

ritiek commented Jan 16, 2022

Thanks for the recommendation. I'm a bit worried about using exec() in the setup file, perhaps it'd be better to use something like setuptools-scm or versioneer. Do you have experience with either of them?

I think exec() might not be so bad here, although I'm not very sure myself either. I haven't tried out setuptools-scm or versioneer yet. This looks like a trade-off between uncertainty and adding a new dependency, so completely up to you what seems like a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants