Add feature to vote on tags (#240) #241
Conversation
Signed-off-by: Thomas Brockmöller <[email protected]>
|
This PR would also solve: #196. |
|
@alastair Do you have any comments on this PR? Do I need to change something before it can be merged? |
|
Bump |
|
Thanks for the contributions, but I'm sorry I really don't have the time to look through this and merge it. If you're able to use your modifications then I encourage you to use them, but I don't want to make any promises on when I can merge this because I don't want to fail on them. |
|
OK, thanks for your reply. I already used this implementation several times. |
|
Bump |
|
Was there anything missing for including it in v0.7? |
| if isinstance(tags, dict): | ||
| for tag, vote in tags.items(): | ||
| usertag_xml = ET.SubElement(taglist, "{%s}user-tag" % NS) | ||
| usertag_xml.set('vote', vote) |
There was a problem hiding this comment.
we should raise an error if the vote parameter isn't a valid value
| @@ -1259,8 +1259,10 @@ def submit_tags(**kwargs): | |||
| """Submit user tags. | |||
| Takes parameters named e.g. 'artist_tags', 'recording_tags', etc., | |||
| and of the form: | |||
| {entity_id1: {tag1: vote, ...}, ...} | |||
There was a problem hiding this comment.
The documentation should be updated to say what the value of "vote" can be - "upvote", "downvote", or "withdraw". I wonder if it also makes sense to support alternate values for for this? Integers? 1, 0, -1? Booleans? True, False, None?
There was a problem hiding this comment.
Thanks for your comments. I will try to update this branch soon.
And I need to check, if the code still works after all those years.
There was a problem hiding this comment.
I improved the documentation now. Is it better now?
For the time being, I would stick with the official values for a vote ("upvote", "downvote", "withdraw"). At the moment, I'm not convinced to include a logic to convert boolean of interger values to this specific strings.
|
@alastair It's ready for review. |
|
Ping :) |
|
I opened this PR four years ago and got very little feedback. Is there any interest in it, @alastair? If not, please let me know and I can close it. |
|
I'm very disappointed... I'm closing this PR now. |
Votes can be submitted in the following format:
{entity_id1: {tag1: vote, ...}, ...}e.g.:
{'releaseId': {'tag_1': 'upvote', ...}, ...}Therefore, I extended the make_tag_request function. The previous functionality is still the same.
I already tested it on test.musicbrainz.org. But I'm not sure how to write a proper test for it.