Fix shutdown of config monitor #7936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisduerr
commented
Apr 28, 2024
kchibisov
approved these changes
May 3, 2024
There was a problem hiding this comment.
I think the original issue was part of the notify crate spawning their own thread and there was no way to join it.
If you look into watchers, they do send Shutdown for example, but none of them actually wait/join anything, so it still kind of doesn't wait properly, I think.
I'm not sure that it matters much for this patch, since we generally want to join, it's just, not sure that the original FIXME is actually fixed.
chrisduerr
force-pushed
the
clean_monitor_shutdown
branch
from
a88c0df
to
2235c3b
Compare
This implements a coordinated shutdown of the config monitor by sending an event to its thread and waiting for the thread to terminate.
chrisduerr
force-pushed
the
clean_monitor_shutdown
branch
from
9a26556
to
45b4a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a coordinated shutdown of the config monitor by sending an event to its thread and waiting for the thread to terminate.