Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix macOS creating tab in startup_mode = Fullscreen #7885

Closed
wants to merge 5 commits into from

Conversation

Uziniii
Copy link

@Uziniii Uziniii commented Mar 30, 2024

When startup_mode was set to Fullscreen, creating a new tab would cause the tab to be set as Fullscreen too
Tab being Fullscreen cause a new window to be created instead of doing a tab

Copy link
Member

@chrisduerr chrisduerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation behind this PR? This sounds extremely opinionated and I do not see what startup mode has to do with anything here, considering fullscreen can be entered at any point during runtime.

@Uziniii
Copy link
Author

Uziniii commented Mar 31, 2024

That linked to this issue #7626
sorry i forgot to link it

@chrisduerr
Copy link
Member

You're not fixing the issue though.

@chrisduerr chrisduerr closed this Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants