Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrollbar #7231

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Add scrollbar #7231

wants to merge 29 commits into from

Commits on Sep 20, 2023

  1. Add non-interactive scrollbar 

    Part of alacritty#775.
    @flash-freezing-lava
    flash-freezing-lava committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    3e532ce View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Reserve space in case of scrollbar mode Always

    @flash-freezing-lava
    flash-freezing-lava committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    31e6164 View commit details
    Browse the repository at this point in the history

  2. Fix tabs in documentation

    @flash-freezing-lava
    flash-freezing-lava committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    487a53b View commit details
    Browse the repository at this point in the history

  3. Write out let-else

    @flash-freezing-lava
    flash-freezing-lava committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    23d09ac View commit details
    Browse the repository at this point in the history

  4. Don't hide scrollbar when no scrollback exists 

    Now is more similar to other terminals and less to browsers.
    @flash-freezing-lava
    flash-freezing-lava committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    0b6edc0 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2023

  1. Move scrollbar to own module

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    9e9a7d7 View commit details
    Browse the repository at this point in the history

  2. Only damage scrollbar on change

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    39d6f4a View commit details
    Browse the repository at this point in the history

  3. Move rect calculation to Scrollbar

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    4061124 View commit details
    Browse the repository at this point in the history

  4. Add experimental scrollbar dragging

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    ec16444 View commit details
    Browse the repository at this point in the history

  5. Move scrollbar into padded area

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    2545c2c View commit details
    Browse the repository at this point in the history

  6. Only drag scrollbar on left mouse button

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    3c2f3f9 View commit details
    Browse the repository at this point in the history

  7. Don't continue select scrolling

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e3aabd1 View commit details
    Browse the repository at this point in the history

  8. Indicate scrollbar state in cursor icon

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    8433383 View commit details
    Browse the repository at this point in the history

  9. Fix: Scrollbar position is incorrect if height gets corrected 

    The bug was visible when having enough text, that the scrollbar was
coerced to be at least min_height. In that case, the scrollbar was
positioned such that it exceeded the display area.
    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    0747d76 View commit details
    Browse the repository at this point in the history

  10. Fix overflow if scrollbar spans whole height

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    0b7f032 View commit details
    Browse the repository at this point in the history

  11. Support scrollbar dragging via touchpad

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    1464f26 View commit details
    Browse the repository at this point in the history

  12. Clarify how scroll of scrollbar is applied

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    5d02bbf View commit details
    Browse the repository at this point in the history

  13. Make waiting fraction of scrollbar fade animation constant

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    0673899 View commit details
    Browse the repository at this point in the history

  14. Set scrollbar width constant at the cell width

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    a680acd View commit details
    Browse the repository at this point in the history

  15. Show cursor change immediately on scrollbar drag and hover

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e0dd6fa View commit details
    Browse the repository at this point in the history

  16. Set scrollbar minimum height constant based the cell height

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e1151f3 View commit details
    Browse the repository at this point in the history

  17. Repeat window padding instead of separate scrollbar margin

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    447393d View commit details
    Browse the repository at this point in the history

  18. Update CHANGELOG

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    4d9b6dd View commit details
    Browse the repository at this point in the history

  19. Don't call scrollbar functions if disabled in config 

    This fixes issues in tests, where alacritty is tested without display
and therefore also without scrollbar. Previously it panicked because the
display was unimplemented.
    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    60df73f View commit details
    Browse the repository at this point in the history

  20. Hide scrollbar in fading mode if full screen is covered

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    4451296 View commit details
    Browse the repository at this point in the history

  21. Don't redraw frame while waiting for scrollbar fading

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    e11e8b4 View commit details
    Browse the repository at this point in the history

  22. Don't fade out scrollbar while dragging

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    c378b5d View commit details
    Browse the repository at this point in the history

  23. Add common derives to scrollbar types

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    15be6d5 View commit details
    Browse the repository at this point in the history

  24. Fix: Scrollbar not fading when swapping windows in animation

    @flash-freezing-lava
    flash-freezing-lava committed Oct 7, 2023
    Configuration menu
    Copy the full SHA
    4fec552 View commit details
    Browse the repository at this point in the history