Optimize terminal full damage #5858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
force-pushed
the
optimize-full-damage
branch
3 times, most recently
from
1709a7f
to
241c8ce
Compare
kchibisov
force-pushed
the
optimize-full-damage
branch
from
477b3a7
to
037ba09
Compare
When terminal should be fully damaged we only want to occupied cells, thus now alacritty_terminal always returns `TermDamageIterator`, but when terminal was fully damaged it damages all the lines from 0 up to line.occ. That helps a lot with something like `yes` or when scrolling scrollback buffer by reducing the amount of damaged area.
kchibisov
force-pushed
the
optimize-full-damage
branch
from
a02bca6
to
480ba15
Compare
|
|
|
Closing in favor of #5863. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When terminal should be fully damaged we only want to occupied cells,
thus now alacritty_terminal always returns
TermDamageIterator, butwhen terminal was fully damaged it damages all the lines from 0 up to
line.occ. That helps a lot with something like
yesor when scrollingscrollback buffer by reducing the amount of damaged area.