Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid open cmd terminal running on windows #581

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

albfan
Copy link
Collaborator

@albfan albfan commented May 5, 2021

Summary / How this PR fixes the problem?

Property for meson build system to run as GUI on windows

Steps to Test

Execute exe on windows and see it doesn't open a cmd terminal to show the logs

Screenshots

N/A

Known Issues / Things To Do

N/A

This PR fixes/implements the following bugs/features:

N/A

@Alecaddd Alecaddd self-requested a review May 7, 2021 02:29
@Alecaddd
Copy link
Member

Alecaddd commented May 7, 2021

I'm getting this while building with meson:

src/meson.build:151: WARNING: Passed invalid keyword argument "win_subsystem".
WARNING: This will become a hard error in the future.

@albfan
Copy link
Collaborator Author

albfan commented May 7, 2021

this argument was ``gui_app:true` prior to meson 0.56. After that version, it is deprecated but still works.

See it on https://mesonbuild.com/Reference-manual.html#executable

Looks that's what happen, seing ubuntu meson package:

https://packages.ubuntu.com/search?keywords=meson

windows msys2 version is patched with +0.56 meson:

https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-akira/Avoid-open-cmd-terminal-running-on-windows.patch

But will rework this to avoid patches for next releases

@Alecaddd Alecaddd marked this pull request as draft July 14, 2021 03:38
@Alecaddd
Copy link
Member

Converting this to Draft so we know it needs some work.
Feel free to mark it ready for a full review once the issue with meson is fixed.

@albfan
Copy link
Collaborator Author

albfan commented Jul 15, 2021

I'm on meson 0.58, should I do conditional compilation for meson >0.56

https://en.wikipedia.org/wiki/Elementary_OS#Summary_table
https://packages.ubuntu.com/search?keywords=meson

Is elementary on 0.45?

@Alecaddd
Copy link
Member

elementary OS 6 is on v0.53.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants