New installer options (v2) #672
Conversation
This adds support for serveral new command line options (taken from the usage):
- `-b, --bin-dir Override the bin installation directory`
- `-m, --man-dir Override the man installation directory`
- `-a, --arch Override the architecture identified by the installer`
- `-h, --help Display this help message`
This also (coincidentally) allows for $BIN_DIR, $MAN_DIR, and $ARCH to be set to create default settings for these.
These variables are *always* overwritten by the command line arguments.
This helps ensure that mismatched permission on `_bin_dir` and `_man_dir` don't cause issues. Also prevents creating man pages owned by root being written to the user's $HOME
This prevents attempting to create files in `/` if a path is not given, instead failing early.
They now suggest passing to `sh`, rather than `bash`, to match the shebang and reduce posibility that non-posix behaivor of `bash` affects the script. this was requested by @ajeetdsouza
Since the installation instructions now recommend using `sh`, check that this implementation *does* support local before continuing.
This ensures that odd values for _bin_name, _bin_dir, and others aren't treated as options to the command and cause a failure.
Remove the display of this default value, since we can't detect it without erroring before usage.
|
@ajeetdsouza I hope I've accomplished what you expected when we first discussed this (almost a year ago) here. |
the ci requires that you run `shfmt -w --indent=4 --language-dialect=posix --simplify *.sh'`, and as such, i now have. note: I also formatted the case statement in parse_args to fit on one screen while still being readable.
ajeetdsouza
force-pushed
the
main
branch
2 times, most recently
from
d72d9ce
to
cbb8e77
Compare
|
I used the official install script for the first time today, because of the outdated Debian 11 package. Right away I was surprised by the hard-coded |
|
Thank you for the new configuration options. They make automation easier for me, and I have already updated my jobs accordingly. |
|
Thank you @aarondill for the PR. |
This is a rewrite of #590 to reduce the diff and make it a more reasonable pr.
Add support for options in install script
This adds support for serveral new command line options (taken from the usage):
-
-b, --bin-dir Override the bin installation directory-
-m, --man-dir Override the man installation directory-
-a, --arch Override the architecture identified by the installer-
-h, --help Display this help messageThis also (coincidentally) allows for $BIN_DIR, $MAN_DIR, and $ARCH to be set to create default settings for these.
These variables are always overwritten by the command line arguments.