Add support for cmd.exe (experimental)
#567
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeetdsouza
reviewed
May 10, 2023
mataha
commented
Jun 5, 2023
| @@ -94,6 +98,22 @@ mod tests { | |||
| } | |||
|
|
|||
| #[apply(opts)] | |||
| #[cfg(windows)] | |||
| fn cmd_cmd(cmd: Option<&str>, hook: InitHook, echo: bool, resolve_symlinks: bool) { | |||
There was a problem hiding this comment.
This won't run as #[cfg(feature = "nix-dev")] is in effect. Should I pull it to a separate module?
|
It is ready. |
|
This is awesome! I'm learning Batch as I review this, so forgive the intermittent comments. |
ajeetdsouza
reviewed
Jun 11, 2023
ajeetdsouza
reviewed
Jun 11, 2023
mataha
added a commit
to mataha/zoxide
that referenced
this pull request
Aug 16, 2023
When it comes to resolving paths on Windows, even though the underlying API expects drive letter prefixes to be uppercase, some sources (e.g. environment variables like `=C:`) won't normalize components, instead returning the value as-is. While this wouldn't be a problem normally as NTFS is case-insensitive on Windows, this introduces duplicates in the database when adding new entries via `zoxide add`: ```batchfile prompt > zoxide query --list D:\ d:\ D:\coding d:\coding D:\coding\.cloned d:\coding\.cloned ``` This is a cherry-pick from ajeetdsouza#567; see also rust-lang/rust-analyzer#14683. Signed-off-by: mataha <[email protected]>
ajeetdsouza
force-pushed
the
main
branch
3 times, most recently
from
4a7505d
to
073500c
Compare
mataha
added a commit
to mataha/zoxide
that referenced
this pull request
Dec 15, 2023
When it comes to resolving paths on Windows, even though the underlying API expects drive letter prefixes to be uppercase, some sources (e.g. environment variables like `=C:`) won't normalize components, instead returning the value as-is. While this wouldn't be a problem normally as NTFS is case-insensitive on Windows, this introduces duplicates in the database when adding new entries via `zoxide add`: ```batchfile prompt > zoxide query --list D:\ d:\ D:\coding d:\coding D:\coding\.cloned d:\coding\.cloned ``` This is a cherry-pick from ajeetdsouza#567; see also rust-lang/rust-analyzer#14683. Signed-off-by: mataha <[email protected]>
ajeetdsouza
force-pushed
the
main
branch
2 times, most recently
from
d72d9ce
to
cbb8e77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #218.
This PR adds experimental support for
cmd.exeusing the following Batch techniques:for /fwith disappearing caretsMost of the work was done in a0c6535 -
%characters have different meanings depending on the context in which the code is interpreted (command-line vs script), thus the beginning of the template file introduces a macro used to escape them regardless of the situation - even inforstatements.While working on this I had to fix path normalization on Windows in bc947f4, i.e. patching drive letter prefixes to always be uppercase (as that's how the underlying API expects them to be, even though
cmd.exewill happily return an unnormalized component from volume path environment variable). A similar problem was encountered in rust-analyzer, which made me provide a fix there. To offset the potential overhead I've bumpeddunceto 1.0.4 in 2fdde1c, though most of the changes there are related to licensing and packaging.To test this,
zoxide init cmdis piped intocmd.exe- anything on stderr means failure, e.g.: