Fix timing of layout margin layout invalidation for bars #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brynbodayle
reviewed
Apr 22, 2024
brynbodayle
reviewed
Apr 22, 2024
brynbodayle
approved these changes
Apr 22, 2024
bryankeller
force-pushed
the
bk/fix-bar-layout-margin-layout-timing
branch
from
e37cdcf
to
262be39
Compare
bryankeller
force-pushed
the
bk/fix-bar-layout-margin-layout-timing
branch
from
262be39
to
af28019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
This PR fixes the timing of layout and size invalidation when the layout margins change on an
EpoxySwiftUIHostingView. For now, this only affects bar models, since those seem more likely to benefit from this change due to the the timing of layout margins being set during view controller transitions.How was it tested?
How did you verify that this change accomplished what you expected? Add more detail as needed.
Pull request checklist
All items in this checklist must be completed before a pull request will be reviewed.
CollectionViewConfigurationCHANGELOG.mdentry in the "Unreleased" section for any library changes