Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable i18n #1024

Closed

Conversation

tobySolutions
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

I disabled i18n across the codebase and properly handle the locale's status that was causing the translations to auto-change now. The codebase is cleaner, and users in other non-english speaking countries that were complaining of pages breaking will no longer due to this PR.

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 0:38am
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 22, 2024 0:38am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@coveralls
Copy link

coveralls commented Apr 18, 2024

Pull Request Test Coverage Report for Build 8776725289

Details

  • 0 of 9 (0.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 3.509%

Changes Missing Coverage Covered Lines Changed/Added Lines %
website/components/home/cta.tsx 0 1 0.0%
website/next.config.mjs 0 1 0.0%
website/components/home/hero.tsx 0 2 0.0%
website/theme.config.tsx 0 2 0.0%
website/hooks/use-translations.ts 0 3 0.0%
Totals Coverage Status
Change from base Build 8310993225: 0.04%
Covered Lines: 884
Relevant Lines: 27914

💛 - Coveralls

Copy link

github-actions bot commented May 8, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label May 8, 2024
@tobySolutions
Copy link
Contributor Author

not stale!

@github-actions github-actions bot closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants