Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: docs review #1023

Closed
wants to merge 3 commits into from

Conversation

tobySolutions
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

In this PR I went over parts of the docs that are outdated, took them out and I added a new section on installation with demo examples to help users that want to understand how to setup Million in their stacks. I will be maintaining these codebases with latest feature changes and version changes

Status

  • Code changes have been tested against prettier, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the codebase
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
    • This PR changes the internal workings with no modifications to the external API (bug fixes, performance improvements)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
million-kitchen-sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 8:05pm
sink ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2024 8:05pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! A maintainer will review it soon.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8743980437

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 3.469%

Totals Coverage Status
Change from base Build 8310993225: 0.0%
Covered Lines: 884
Relevant Lines: 28240

💛 - Coveralls

Copy link

github-actions bot commented May 4, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within the next 7 days.

@github-actions github-actions bot added the Stale label May 4, 2024
@tobySolutions
Copy link
Contributor Author

not stale!

@github-actions github-actions bot closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants