馃憣 Add Recovery Rate metric #13
Conversation
utils/calcRecoveryRate.js
Outdated
| /** | ||
| * Calculates the recovery rate from an array of data and splices the recovery rate | ||
| * into the middle of the array for table formatting. | ||
| * | ||
| * @param {Array} one data about the element we are processing. (e.g. state, country, etc.) | ||
| * @return {Array} A spliced array almost as it was before but now with a string formatted recovery rate. | ||
| */ | ||
| function spliceRecoveryRate(one) { |
There was a problem hiding this comment.
one is a poor name, as a reader I have no idea what that means.
Perhaps area would be better?
There was a problem hiding this comment.
one is the naming convention already in use in this project elsewhere for a single entry.
There was a problem hiding this comment.
I believe we can make one better everywhere.
|
Thanks a lot @musicaljoeker for sending in a PR. Good stuff. And thank you @Inukares for reviewing it. I'll check it out tomorrow. We'll soon have this here. |
|
Thanks for the PR. Can you please update the PR in light of the latest release. 馃敆 https://github.com/ahmadawais/corona-cli/releases/tag/3.4.0 |
|
Hi @ahmadawais, Sorry for the later response - I was finishing up my grad midterm project this week. I'll be happy to do that. I'll see if I can get to it tonight, but if not, I'll do it tomorrow. |
|
Ok I brought in the latest changes. Should be good to go hopefully 馃 |
|
Hi @ahmadawais, |
This PR resolves the request in #4. I changed the wording from mortality rate to recovery rate out of my own personal preference.
I'm not a JS developer by trade, so please let me know if you have any feedback. This looks like a cool project.