Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 DOC: Add alternative function for Linux user who uses GIMP #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

eclectic-coding
Copy link

PR for issue #21

Copy link
Owner

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @eclectic-coding!

You're not using the Emoji log right. We don't use past tense in commit messages but the imperative order like lingo. Please amend the commit message, PR Title, and address the few comments I left to add all changes inside the code snippets making them less prominent so that users don't have more cognitive load to deal with when they read the docs.

Looking forward, peace! ✌️

README.md Outdated
@@ -125,6 +125,12 @@ function gtst() {
gcap "✅ TEST: $@"
}
```
For Linux user who use the graphical program GIMP, use this alternative IMPROVE function:
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to mention that. Just add the snippet with a comment inside the code snippets instead of making separate sections.

README.md Outdated
@@ -144,6 +150,10 @@ funcsave grlz
funcsave gdoc
funcsave gtst
```
Alternative function for Linux users for IMPROVE in fish shell:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes here, add one extra line with a small comment inside the code snippets.

@eclectic-coding eclectic-coding changed the title 📖 DOC: Added alternative function for Linux user who user GIMP 📖 DOC: Add alternative function for Linux user who uses GIMP Oct 31, 2019
Copy link
Owner

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments should be comments.

@@ -105,6 +105,11 @@ function gimp() {
gcap "👌 IMPROVE: $@"
}

Alternative function for Linux users who use the graphical program GIMP**:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Alternative function for Linux users who use the graphical program GIMP**:
# Alternative for Linux users of GIMP app:

@@ -145,16 +143,13 @@ function gtst; gcap "✅ TEST: $argv"; end;
funcsave gcap
funcsave gnew
funcsave gimp
Alternative function for Linux users for IMPROVE in fish shell:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Alternative function for Linux users for IMPROVE in fish shell:
# Alternative for Linux users of GIMP app:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants