Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark-mode #351

Merged
merged 2 commits into from
Jul 30, 2019
Merged

Add dark-mode #351

merged 2 commits into from
Jul 30, 2019

Conversation

capaldo
Copy link
Collaborator

@capaldo capaldo commented Jul 28, 2019

New App Submission

App name: dark-mode

Repo or homepage link: https://github.com/sindresorhus/dark-mode

Description: Toggle macOS's dark mode from the terminal.

@capaldo capaldo added the needs review Waiting for assessment label Jul 28, 2019
@jneidel
Copy link
Collaborator

jneidel commented Jul 28, 2019

Please change the description from Toggle macOS's dark mode from the terminal. to Toggle dark mode..

Reasoning:

  • its in the macos section, macos can be omitted from the description
  • its on a cli-apps list, xxx from the terminal is unnecessary

@jneidel jneidel added pending Waiting to be mergable and removed needs review Waiting for assessment labels Jul 28, 2019
@jneidel jneidel self-requested a review July 28, 2019 19:18
@capaldo
Copy link
Collaborator Author

capaldo commented Jul 30, 2019

Please change the description from Toggle macOS's dark mode from the terminal. to Toggle dark mode..

Reasoning:

  • its in the macos section, macos can be omitted from the description
  • its on a cli-apps list, xxx from the terminal is unnecessary

I've updated the dark-mode description as you've outlined.

@jneidel
Copy link
Collaborator

jneidel commented Jul 30, 2019

updated dark-mode description

Is not a good commit message. Better would be for example: Update dark-mode description or in the context of this PR you can just use Update description.

For a good reference on writing commit messages.

@jneidel jneidel changed the title add dark-mode Add dark-mode Jul 30, 2019
@jneidel jneidel merged commit 7f03988 into master Jul 30, 2019
@jneidel jneidel deleted the dark-mode branch July 30, 2019 15:44
@capaldo
Copy link
Collaborator Author

capaldo commented Jul 30, 2019

updated dark-mode description

Is not a good commit message. Better would be for example: Update dark-mode description or in the context of this PR you can just use Update description.

For a good reference on writing commit messages.

I did in fact read this prior to contributing again but forgot to not use the non-imperative form. Thanks for pointing that one out again to me.

@jneidel
Copy link
Collaborator

jneidel commented Jul 30, 2019

Capitalization as well 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending Waiting to be mergable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants