Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detach unused pool elements from THREE.js scene #5186

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Detach unused pool elements from THREE.js scene #5186

wants to merge 9 commits into from

Commits on Dec 18, 2022

  1. New attachToScene / detachFromScene methods on entity

    @diarmidmackenzie
    diarmidmackenzie committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    c989c1c View commit details
    Browse the repository at this point in the history

  2. Detach unused pool entities from THREE.js scene 

    This improves performance of updateMatrixWorld() in render cycle.
    @diarmidmackenzie
    diarmidmackenzie committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    ab7c136 View commit details
    Browse the repository at this point in the history

  3. Unit tests for detaching unused pool entities from THREE.js scene

    @diarmidmackenzie
    diarmidmackenzie committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    a23686b View commit details
    Browse the repository at this point in the history

  4. New "attached" component + UTs for it

    @diarmidmackenzie
    diarmidmackenzie committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    e16c8a2 View commit details
    Browse the repository at this point in the history

  5. Handle getAttribute similarly to 'visible'

    @diarmidmackenzie
    diarmidmackenzie committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    7234e15 View commit details
    Browse the repository at this point in the history

  6. Documentation updates for attached component & entity interface changes.

    @diarmidmackenzie
    diarmidmackenzie committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    4fc237f View commit details
    Browse the repository at this point in the history

  7. Fix links in docs

    @diarmidmackenzie
    diarmidmackenzie committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    697fb57 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Add events to auto-update raycast targets

    @diarmidmackenzie
    diarmidmackenzie committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    9c03129 View commit details
    Browse the repository at this point in the history

  2. Work around docsLint.js error 

    docsLint.js appears to not like URLs that end with a "-", though this is necessary to link to the anchors for these functions...

[error]: docs/components/attached.md
    Page does not exist: [attach]: ../core/entity.md#attachtoscene-
    Page does not exist: [detach]: ../core/entity.md#detachfromscene-
    @diarmidmackenzie
    diarmidmackenzie committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    1e5762c View commit details
    Browse the repository at this point in the history