Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow animating vec3 object3D raw position #5052

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slecorne
Copy link

@slecorne slecorne commented May 5, 2022

Description:
Allow animating vec3 position directly on Object3D at once.
Currently we can animate object3D position axis using property: object3D.position.z but not the complete vec3 at once.
The goal is to be able to animate the vec3 position directly through object3D without using setAttributes.
The current alternative to animate position directly through object3D is to perform 3 animations which has important performance issue.

Changes proposed:

  • Adding type: position similar to raw color animation detection
  • In that case animate directly vec3 object3d.position
  • Tests + documentation update

Feedback welcome

@slecorne slecorne changed the title Allow animation vec3 object3D position Allow animating vec3 object3D raw position May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant