Added support for retrieving certificates when asynchronous order finalization is enabled on the ACME server-side. #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desc
This fixes issue #63, which is due to the following (partially planned) change at the ACME server implementation level:
https://community.letsencrypt.org/t/enabling-asynchronous-order-finalization/193522
Tests
I've tested it against LE Staging & LE Live successfully.
Implementation details
The
getCertificate()
method in theClient
class has been updated to handle cases where the certificate is not immediately available and retries fetching the certificate until it becomes valid.This also introduces a new (private) method
getCertificateChain()
in theClient
class, which is used to fetch the certificate chain from the ACME API to avoid implementing the same code multiple times.Additionally, the
Order
class has been updated to include the newcertificate
property and a correspondinggetCertificate()
getter method.