Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis CI build for linux #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bitnot
Copy link
Contributor

@bitnot bitnot commented Oct 12, 2021

Follow up on 99bcd4d
Sets the LIBDIR variable to lib.

Failing build
Passing build

@bitnot
Copy link
Contributor Author

bitnot commented Oct 12, 2021

@aetilius, @G10h4ck could you check if this makes sense?

Another note: it seems that Travis is having some trouble running the builds from the main repo:

Screenshot 2021-10-12 at 18 31 58

s

@aetilius
Copy link
Owner

Thanks @bitnot. I believe the travis issue is fixed now, are you able to confirm?

@G10h4ck
Copy link
Contributor

G10h4ck commented Oct 15, 2021

The latest change i committed and is already merged in master should fix this already more automatically so this extra change should be not necessary

@bitnot
Copy link
Contributor Author

bitnot commented Oct 16, 2021

Thanks @bitnot. I believe the travis issue is fixed now, are you able to confirm?

Hey @aetilius.
Builds seems to be working now - see #30

I think you would have to push a new commit to make sure Travis CI can start the build.
You can see the past builds failed to start here: https://app.travis-ci.com/github/aetilius/pHash/requests

And just to make sure we are on the same page, the issue I am referring to is "Could not authorize build request for aetilius/pHash". You might want to check how you Travis CI plan is configured.

The latest change i committed and is already merged in master should fix this already more automatically so this extra change should be not necessary

@G10h4ck ,
The purpose of this PR is to fix a very specific environment - Travis CI bionic linux.
I am not familiar with CMake or building C on Linux, so forgive me if I am suggesting nonsense, but it seems to me that Travis CI does not initialize the LIBDIR properly.

On top of that there is (was?) an issue in general preventing builds in the original aetilius/pHash to start (see above). It works fine in my fork however.

@bitnot bitnot changed the title Fix CI build for linux Fix Travis CI build for linux Oct 16, 2021
@bitnot bitnot closed this Oct 17, 2021
Follow up on 99bcd4d
Sets the `LIBDIR` variable to `lib`.

[Failing build](https://github.com/bitnot/pHash/runs/3861809127)
[Passing build](https://github.com/bitnot/pHash/runs/3861825744)
@bitnot bitnot reopened this Oct 17, 2021
@G10h4ck
Copy link
Contributor

G10h4ck commented Oct 18, 2021

Ok for me to merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants