Add functions to fetch funding rate data from market #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adshao
approved these changes
Apr 22, 2024
|
thank you @Issengaard |
adshao
requested changes
Apr 22, 2024
Comment on lines
66
to
78
| func TestName(t *testing.T) { | ||
| client := NewClient("", "") | ||
|
|
||
| ctx, cancelFunc := context.WithDeadline(context.Background(), time.Now().Add(time.Second*5)) | ||
| defer cancelFunc() | ||
|
|
||
| rateHistory, err := client.NewFundingRateHistoryService().Do(ctx) | ||
| require.NoError(t, err) | ||
|
|
||
| for i := 0; i < 5; i++ { | ||
| fmt.Printf("%+v\n", rateHistory[i]) | ||
| } | ||
| } |
There was a problem hiding this comment.
Please remove these lines of code which make unit tests failed: https://github.com/adshao/go-binance/actions/runs/8418016069/job/24101016684?pr=552#step:6:554
There was a problem hiding this comment.
Good day! Upps, I'm sorry, I have forgot to remove test function, that had made to check function results. I have removed it in new commit.
adshao
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The market client has been modified to enable the retrieval of funding rate data with the following changes:
Tests for the new functions have been created following the same approach as other tests in the package.