update WsUserDataEvent struct #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, @adshao Please review this change. |
|
Hi @XanderShum , sorry for the late review. Could you please add more unit tests for the code changes? |
|
Hi, @adshao I have updated the unit tests, please review this change. |
adshao
approved these changes
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the WsUserDataEvent struct according to the latest version of Binance documentation and solve the current case sensitivity problem.
This update has to make a few changes that break compatibility. Currently, only the e and E fields are common to all events. There is a problem that fields with the same name have different meanings and types in different events.
For example, the field "u" is the last update timestamp of the account in the outboundAccountPosition event, but it is the Trade Group Id in the executionReport event.
Field "a" represents the asset in the outboundAccountPosition and balanceUpdate events and is of type string, but represents the Allocation ID in the executionReport event and is of type int.
In view of this, I have moved the fields "T" and "u" out of the shared fields to avoid possible bugs in the future.