Add "pu" final update Id in last stream(ie u in last stream)
#489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adshao
reviewed
May 17, 2023
|
@adshao i have tried running it but for some reason binance does not return the "pu" field from their side, which is quite interesting as their documentation states that it should be available, may be i have missed some details. If you have some tips would be great! I have also fixed missing Event value on the Combined Feed |
|
Please also fix the unit test error: https://github.com/adshao/go-binance/actions/runs/5004262748/jobs/9001267285?pr=489 |
|
@adshao doing abit more investigation looks like this only works for the fstream from binance instead of the stream we subscribe to in the library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Binance specs we should be using "pu" (Final update Id in last stream(ie
uin last stream) to detect that our local order book is out of order. This PR adds pu to theWsDepthEventhttps://binance-docs.github.io/apidocs/futures/en/#how-to-manage-a-local-order-book-correctly