Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NOTIONAL filter support #481

Merged
merged 1 commit into from
May 9, 2023
Merged

Add NOTIONAL filter support #481

merged 1 commit into from
May 9, 2023

Conversation

mm2175
Copy link
Contributor

@mm2175 mm2175 commented Apr 15, 2023

I found some symbols filter have changned in binance, eg. for maticusdt, the following format is returned:

        {
          "filterType": "NOTIONAL",
          "minNotional": "5.00000000",
          "applyMinToMarket": true,
          "maxNotional": "9000000.00000000",
          "applyMaxToMarket": false,
          "avgPriceMins": 5
        },

@adshao
Copy link
Owner

adshao commented Apr 22, 2023

Thanks for the update, could you please rebase master branch and update your code?

@mm2175
Copy link
Contributor Author

mm2175 commented Apr 25, 2023

Thanks for the update, could you please rebase master branch and update your code?

Sure, already done this.

@mm2175 mm2175 force-pushed the master branch 3 times, most recently from 67eeae6 to 13b4400 Compare April 25, 2023 02:49
@adshao
Copy link
Owner

adshao commented Apr 27, 2023

Hi @mm2175 , could you please fix the vet error here

@mm2175 mm2175 force-pushed the master branch 3 times, most recently from 9ac6a8f to 3a65061 Compare April 27, 2023 11:46
@mm2175
Copy link
Contributor Author

mm2175 commented Apr 27, 2023

@adshao fixed.

v2/futures/client.go Outdated Show resolved Hide resolved
@mm2175 mm2175 force-pushed the master branch 2 times, most recently from a1afaf5 to b897861 Compare May 5, 2023 12:37
@adshao adshao merged commit 217b5ca into adshao:master May 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants