support setting WebSocket Base URL #434
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asamere
commented
Nov 8, 2022
| } | ||
|
|
||
| // failing to set the websocket base url prior to use can lead to | ||
| // interesting scenarios syncing an order bool when the rest client |
Codecov Report
@@ Coverage Diff @@
## master #434 +/- ##
==========================================
+ Coverage 69.91% 69.96% +0.04%
==========================================
Files 76 76
Lines 7167 7171 +4
==========================================
+ Hits 5011 5017 +6
+ Misses 1624 1623 -1
+ Partials 532 531 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
norunners
reviewed
Nov 12, 2022
Comment on lines
+26
to
27
| func init() { | ||
| if UseTestnet { |
There was a problem hiding this comment.
Do not use init with a mutable global. It's likely to run before UseTestnet is set.
There was a problem hiding this comment.
hi @asamere , check this comment, I agree with @norunners . UseTestnet could be updated after init.
|
Yes, websocket service should be done in the a client instance. Would you like to create a pull request for this improvement? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be better to create an instance to manage the websocket interactions as is done for the rest client. this is gets it done on my end.