Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a "Symbols" parameters to ListPricesService #388

Merged
merged 2 commits into from
Jul 9, 2022
Merged

Added a "Symbols" parameters to ListPricesService #388

merged 2 commits into from
Jul 9, 2022

Conversation

blarsy
Copy link
Contributor

@blarsy blarsy commented Jul 1, 2022

#380
Added the "Symbols" parameters as specified in https://github.com/binance/binance-spot-api-docs/blob/master/rest-api.md#symbol-price-ticker
Corresponding unit test "TestListPricesForMultipleSymbols" was added, too.

v2/ticker_service.go Outdated Show resolved Hide resolved
v2/ticker_service.go Outdated Show resolved Hide resolved
v2/ticker_service.go Outdated Show resolved Hide resolved
v2/ticker_service.go Outdated Show resolved Hide resolved
@adshao
Copy link
Owner

adshao commented Jul 7, 2022

#380 Added the "Symbols" parameters as specified in https://github.com/binance/binance-spot-api-docs/blob/master/rest-api.md#symbol-price-ticker Corresponding unit test "TestListPricesForMultipleSymbols" was added, too.

Please check the review comments.

@blarsy
Copy link
Contributor Author

blarsy commented Jul 7, 2022

Should be good to go.

@codecov
Copy link

codecov bot commented Jul 7, 2022

Codecov Report

Merging #388 (314d175) into master (815670a) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   70.28%   70.11%   -0.18%     
==========================================
  Files          68       68              
  Lines        6391     6544     +153     
==========================================
+ Hits         4492     4588      +96     
- Misses       1434     1475      +41     
- Partials      465      481      +16     
Impacted Files Coverage Δ
v2/ticker_service.go 78.94% <100.00%> (+1.80%) ⬆️
v2/liquidity_pool_service.go 61.73% <0.00%> (-2.76%) ⬇️
v2/client.go 80.44% <0.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 815670a...314d175. Read the comment docs.

@adshao adshao merged commit 5226fb8 into adshao:master Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants