Fix for method "getUserByUids" with mongodb database #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example code for the `updatePasswordByToken` method is missing the token parameter.
Code examples for custom rules must be added on the class instance
+ remove useless whitespace
async forgeted on updatePasswordByToken() and forgotPassword()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i'm using mongodb as Database, with lucid-mongo.
Unfortunately when Person uses the internal method
getUserByUids()(in the methods verify() and forgotPassword()) fails because tries to search users using the methoduserQuery.orWhere()that doesn't exist in mongo.To fix this would be nice to check if this method exists and fallback to the method
findBy()of mongo.Thank you for your great work.
Best regards,
Florian