Fix correctly handle IME Input in Combobox #6239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to nextui-org/nextui#2121
This PR addresses a bug in the combobox component where inputs from an IME were being incorrectly committed before the user completed their text entry.
β Pull Request Checklist:
before
combobox-ime-before.mov
after
combobox-ime-after.mov
π Test Instructions:
Setup for MacOS
Add the Japanese input method
Test Steps
nihon
followed by the enter key. This should result in "γ«γ»γ" or "ζ₯ζ¬".go
, and the combobox should suggest "γ«γ»γγ". Press enter.π§’ Your Project:
https://github.com/nextui-org/nextui