Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions on how to use argh with tipi.build #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pysco68
Copy link

@pysco68 pysco68 commented Mar 1, 2022

Hey! I just stumbled upon argh during a demo with a customer and used it to demo our tool (they are using it). As depending on it with tipi just worked out of the box I though you may be happy to add the instructions about how to use argh in tipi.build projects to the readme.

I hope this is okay with you. If there's something broken we'd love to help and fix.

P.S.: Full disclaimer: I'm one of the co-founders of tipi.build

@adishavit
Copy link
Owner

Hi @pysco68 - any updated on this?
I wrote some comments on your PR.

@pysco68
Copy link
Author

pysco68 commented May 9, 2022

Hi @adishavit

I didn't get any notification about comments on this PR nor could I find any. Would you mind checking if they have been posted correctly or point me a whereever they are?

Best,
Yannic

@adishavit
Copy link
Owner

See this thread on GitHub.
if you’re reading it in email you should have a link on the bottom.

@pysco68
Copy link
Author

pysco68 commented May 9, 2022

I looked again, and I really can't see any comment. You sure you have submitted the review (no offense)?

grafik

}
```

> `argh` itself is a header-only library hence the exclusion of all `.cpp` files above. This isn't stricly required to inlcude `argh` but speeds up the build.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you say it "speeds up the build."?
There are no .cpp files - it is a header only library.
The .cpp files are only for testing and the example files. You do not need them for using argh.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In tipi we use a source scan based approach to dependency management, instead of having you provide some type of script to make argh usable in someone else's project. Basically when someone adds that line to his .tipi/deps files, tipi will pull argh straight from Github and install it in a project specific sysroot.

By excluding the *.cpp files that are not actually part of argh (but rather only test cases and examples) these files are not being scanned or compiled which can save a bit of time.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't completely understand.

So is adding that json snippet with the *.cpp needed or not?
Is there some way or a need to exclude stuff?

@adishavit
Copy link
Owner

The GH UI confused me - check now..
really just a single comment...

@pysco68
Copy link
Author

pysco68 commented May 9, 2022

No worries ;) The code review UI is not stellar IMHO. Confuses the heck out of anyone I guess, plus the code hiding in the diffs makes some changes very hard to review.

@adishavit
Copy link
Owner

Please add your README example usage under the new, collapsable, Additional Build Systems section.
Make sure it unfolds as a single-cell-table like Buck does now (latest commit).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants