fix: make key a requirement for option API

adbayb · Mar 28, 2022 · e595089 · e595089
1 parent e7f023f
commit e595089
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/src/api/option/index.ts b/src/api/option/index.ts
@@ -44,18 +44,12 @@ export const createOption =
 
 export type OptionParameters<
  Values extends ObjectLikeConstraint,
- Key
+ Key extends keyof Values
 > = InstructionParameters<
  Values,
- Key extends keyof Values
- ? InstructionKey<Key> &
- CommonParameters & {
- defaultValue?: Values[Key];
- }
- : CommonParameters
+ InstructionKey<Key> & {
+ name: string | { long: string; short: string };
+ description: string;
+ defaultValue?: Values[Key];
+ }
 >;
-
-type CommonParameters = {
- name: string | { long: string; short: string };
- description: string;
-};
diff --git a/src/termost.ts b/src/termost.ts
@@ -33,7 +33,9 @@ export type Termost<Values extends ObjectLikeConstraint = EmptyObject> = {
  input<Key extends keyof Values>(
  params: InputParameters<Values, Key>
  ): Termost<Values>;
- option<Key>(params: OptionParameters<Values, Key>): Termost<Values>;
+ option<Key extends keyof Values>(
+ params: OptionParameters<Values, Key>
+ ): Termost<Values>;
  task<Key>(params: TaskParameters<Values, Key>): Termost<Values>;
 };