improvement(index.js): remove the check for first letter should be ca…

…pital in commit message
ad1992 · Mar 26, 2020 · 887cfa1 · 887cfa1
1 parent af22bdc
commit 887cfa1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -5332,11 +5332,6 @@ async function verifyCommits(repoToken) {
  isCommitBad = true;
  }
 
- if (message[0] !== message[0].toUpperCase()) {
- error(`commit message \"${message}\" should have first letter in upper case`);
- isCommitBad = true;
- }
-
  const badKeywords = filterCommit(message);
  if (badKeywords.length) {
  error(`commit message \"${message}\" contains ${badKeywords.join()}`);
@@ -5349,7 +5344,7 @@ async function verifyCommits(repoToken) {
  }
  }
  if (badCommits) {
- throw Error(`${badCommits} have been encountered. Please fix the above errors`);
+ throw Error(`${badCommits} bad commit(s) encountered. Please fix the above errors`);
  }
 }
 async function main() {
@@ -5358,7 +5353,7 @@ async function main() {
  await verifyCommits(repoToken);
  debug('Recieved repo token');
  } catch (e) {
- setFailed(`Action failed with error ${e.message}`);
+ setFailed(`Action failed with error: ${e.message}`);
  }
 }
 

diff --git a/index.js b/index.js
@@ -30,11 +30,6 @@ async function verifyCommits(repoToken) {
  isCommitBad = true;
  }
 
- if (message[0] !== message[0].toUpperCase()) {
- error(`commit message \"${message}\" should have first letter in upper case`);
- isCommitBad = true;
- }
-
  const badKeywords = filterCommit(message);
  if (badKeywords.length) {
  error(`commit message \"${message}\" contains ${badKeywords.join()}`);
@@ -47,7 +42,7 @@ async function verifyCommits(repoToken) {
  }
  }
  if (badCommits) {
- throw Error(`${badCommits} have been encountered. Please fix the above errors`);
+ throw Error(`${badCommits} bad commit(s) encountered. Please fix the above errors`);
  }
 }
 async function main() {
@@ -56,7 +51,7 @@ async function main() {
  await verifyCommits(repoToken);
  debug('Recieved repo token');
  } catch (e) {
- setFailed(`Action failed with error ${e.message}`);
+ setFailed(`Action failed with error: ${e.message}`);
  }
 }