Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Electron] Updated electron to latest stable version #2749

Closed
wants to merge 12 commits into from
Closed

[Electron] Updated electron to latest stable version #2749

wants to merge 12 commits into from

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented May 13, 2024 •
edited

Updated Electron to the latest stable version.

Releases: https://www.electronjs.org/docs/latest/tutorial/electron-timelines

  • Tested on Linux Mint Debian Edition and Windows 10
  • I had to regen the yarn.lock file due to node-abi dependency after the update.

Waiting on this guy: electron/electron#41839

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 13, 2024
@netlify Netlify
Copy link

netlify bot commented May 13, 2024 •
edited

✅ Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 34850df
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/664516526350a200092866f9
😎 Deploy Preview https://deploy-preview-2749.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.72 MB → 4.72 MB (-1 B) -0.00%
Changeset
File Δ Size
package.json 📉 -1 B (-0.03%) 2.85 kB → 2.85 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3 MB → 3 MB (-1 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.81 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.54 kB 0%
static/js/wide.js 261.78 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 13, 2024 •
edited

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@MikesGlitch MikesGlitch changed the title updates to electron Update electron to latest stable version May 13, 2024
@MikesGlitch MikesGlitch changed the title Update electron to latest stable version [Electron] Updated electron to latest stable version May 14, 2024
@youngcw
Copy link
Contributor

youngcw commented May 15, 2024

were you able to test both the appimage and flatpak on linux?

joel-jeremy and others added 7 commits May 15, 2024 21:08
@joel-jeremy @MikesGlitch
Auto insert decimals to mobile split transaction amounts (actualbudge…
64432f8 
…t#2746)

* Auto insert decimals to mobile split transaction amounts

* autoDecimals prop

* Fix typecheck error
@psybers @MatissJanis @MikesGlitch
Add API for working with rules (actualbudget#2568)
7b9f49e 
* Add API for working with rules

* Add release note

* Change 'payees-get-rules' return type to RuleEntity[]

* Reuse existing handlers, make names not have 'payee', add two getters

* fix linter

* fix bad handler name

* fix broken handler name

* add test cases for 'getPayeeRules'

* fix broken test

* Remove unused locals

* Update packages/loot-core/src/types/api-handlers.d.ts

Co-authored-by: Matiss Janis Aboltins <[email protected]>

* Update packages/loot-core/src/types/server-handlers.d.ts

Co-authored-by: Matiss Janis Aboltins <[email protected]>

* Strict types and slightly improved return interface

* update test comment to match new API names

* fix linter issues

---------

Co-authored-by: Matiss Janis Aboltins <[email protected]>
@carkom @MikesGlitch
Custom Reports: TS strict changes actualbudget#2 (actualbudget#2727)
61cf67c 
* TS strict changes

* notes

* TS strict custom spreadsheets

* notes

* render row changes

* update report

* notes
@joel-jeremy @MikesGlitch
[Mobile] Do not remember last entered category in mobile transaction …
836fc95 
…entry (actualbudget#2754)

* Do not remember last entered category in mobile transaction entry

* Release notes
@MatissJanis @MikesGlitch
♻️ (tooltip) refactoring to react-aria (vol.4) (actualbudget#2724)
5b1d8cc
@MatissJanis @MikesGlitch
🐛 (api) fix performing api operations for local e2e encrypted files (a…
de9b1d1 
…ctualbudget#2698)
@MikesGlitch
fixed yarn lock without regen
34850df
@MikesGlitch MikesGlitch deleted the updating-electron-latest-stable branch May 15, 2024 20:26
@MikesGlitch
Copy link
Contributor Author

were you able to test both the appimage and flatpak on linux?

I gave up on this draft PR- here's the one ready for review: #2763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MikesGlitch @youngcw @joel-jeremy @psybers @carkom @MatissJanis