Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto insert decimals to mobile split transaction amounts #2746

Merged
merged 3 commits into from May 14, 2024

Conversation

joel-jeremy
Copy link
Contributor

No description provided.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label May 13, 2024
@github-actions github-actions bot changed the title Auto insert decimals to mobile split transaction amounts [WIP] Auto insert decimals to mobile split transaction amounts May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 1bab985
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66427480dd1a9d00080837c7
😎 Deploy Preview https://deploy-preview-2746.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 13, 2024
Copy link
Contributor

github-actions bot commented May 13, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.72 MB → 4.72 MB (+313 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/shared/util.ts 📈 +483 B (+8.42%) 5.6 kB → 6.07 kB
src/components/util/AmountInput.tsx 📈 +151 B (+4.25%) 3.47 kB → 3.62 kB
src/components/mobile/transactions/TransactionEdit.jsx 📈 +36 B (+0.11%) 30.79 kB → 30.82 kB
src/components/mobile/transactions/FocusableAmountInput.tsx 📉 -357 B (-5.63%) 6.19 kB → 5.84 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3 MB → 3 MB (+313 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 59.81 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 20.54 kB 0%
static/js/wide.js 262.4 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

github-actions bot commented May 13, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB → 1.2 MB (+219 B) +0.02%
Changeset
File Δ Size
packages/loot-core/src/shared/util.ts 📈 +524 B (+5.41%) 9.46 kB → 9.97 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.2 MB → 1.2 MB (+219 B) +0.02%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

@joel-jeremy joel-jeremy changed the title [WIP] Auto insert decimals to mobile split transaction amounts Auto insert decimals to mobile split transaction amounts May 13, 2024
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels May 13, 2024
Copy link
Contributor

@youngcw youngcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels May 14, 2024
@joel-jeremy joel-jeremy merged commit 9acea32 into master May 14, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the auto-insert-decimals-on-mobile-split-transactions branch May 14, 2024 14:49
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels May 14, 2024
MikesGlitch pushed a commit to MikesGlitch/actual that referenced this pull request May 15, 2024
…t#2746)

* Auto insert decimals to mobile split transaction amounts

* autoDecimals prop

* Fix typecheck error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants