Skip to content

Commit

Permalink
Update dependencies and improve CI workflow
Browse files Browse the repository at this point in the history
- Use strings instead of floats for uniformity
- Rename "deps" with "rails" for uniformity with Inherited Resources and
  Active Admin gems
- Update bundler
- Fix platforms
  • Loading branch information
tagliala committed Jun 15, 2024
1 parent 41ebc98 commit dacbfa7
Show file tree
Hide file tree
Showing 4 changed files with 188 additions and 209 deletions.
18 changes: 9 additions & 9 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
matrix:
ruby:
- "3.0"
- 3.1
- 3.2
- 3.3
deps:
- "3.1"
- "3.2"
- "3.3"
rails:
- rails_61
- rails_70
- rails_71
Expand All @@ -27,11 +27,11 @@ jobs:
- name: Configure bundler (default)
run: |
echo "BUNDLE_GEMFILE=Gemfile" >> "$GITHUB_ENV"
if: matrix.deps == 'rails_71'
if: matrix.rails == 'rails_71'
- name: Configure bundler (alternative)
run: |
echo "BUNDLE_GEMFILE=gemfiles/${{ matrix.deps }}/Gemfile" >> "$GITHUB_ENV"
if: matrix.deps != 'rails_71'
echo "BUNDLE_GEMFILE=gemfiles/${{ matrix.rails }}/Gemfile" >> "$GITHUB_ENV"
if: matrix.rails != 'rails_71'
- uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
Expand All @@ -41,10 +41,10 @@ jobs:
COVERAGE: true
run: |
bundle exec rspec
mv coverage/coverage.xml coverage/coverage-ruby-${{ matrix.ruby }}-${{ matrix.deps }}.xml
mv coverage/coverage.xml coverage/coverage-ruby-${{ matrix.ruby }}-${{ matrix.rails }}.xml
- uses: actions/upload-artifact@v4
with:
name: coverage-ruby-${{ matrix.ruby }}-${{ matrix.deps }}
name: coverage-ruby-${{ matrix.ruby }}-${{ matrix.rails }}
path: coverage
if-no-files-found: error

Expand Down
Loading

0 comments on commit dacbfa7

Please sign in to comment.