Enable Pundit authorization with namespaced decorators #7934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess the testing could do with some love, and perhaps we should add tests for both namespaced and non-namespaced decorators. Am I on the right track here?
What
When retrieving auth policies and the subject is wrapped in a namespaced decorator, Pundit is not able to find the policy. My original issue with full description and code to reproduce is in issue #7933.
How
This fix makes use of
ResourceController::Decorators.undecorate
to undecorate the target before asking pundit to fetch the policy.It does this in
PunditAdaper#policy_target
, so as to have the fix affectPunditAdapter#retrieve_policy
which in turn is used byPunditAdapter#authorized
.Unless I'm missing something the remaining public methods are not affected by the issue at hand.
Fixes #7933