Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update world.h #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update world.h #198

wants to merge 1 commit into from

Conversation

asmanel
Copy link

@asmanel asmanel commented Apr 13, 2016

pCube maps glitch fix

default: \
e.type=NOTUSED; \
} \
} \
if(headr.version>=6 && headr.version<8) { \
if(strncmp(headr.head,"CUBE",4)==1 && (headr.version>=6 && headr.version<8)) { \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing the result of strncmp to 1 is unreliable.

@theonlypwner
Copy link
Member

theonlypwner commented Apr 14, 2016

I have added a link to the pCube project in the first post.

You mentioned that pCube maps have a version number of 6 and "CUBE" magic bytes and old AC v6 maps have "ACMP" magic.

If that's the cause, replacing 6 with 7 in the first and last changed lines should fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants