Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K kumar 01/i295/hyperlink modal popup #297

Closed
wants to merge 2 commits into from
Closed

K kumar 01/i295/hyperlink modal popup #297

wants to merge 2 commits into from

Conversation

K-Kumar-01
Copy link
Contributor

Closes #295

Navigating through the link via arrow keys now doesn't open the popup.

Changes

  • Passed the setShowLinkModal as prop in ElementRenderer
  • Add onClick to the render LINK and removed the selection to check if it is link.

Screenshots or Video

https://www.loom.com/share/50e92dde9b3c4b10a6eb2fe39c76b8c1

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@irmerk irmerk mentioned this pull request Mar 12, 2021
Open
@irmerk
Copy link
Member

irmerk commented Mar 12, 2021

Closing until we have more understanding in #295

@irmerk irmerk closed this Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Going through the link with the popup opens the cursor
2 participants
@K-Kumar-01 @irmerk