-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Going through the link with the popup opens the cursor #295
Comments
@irmerk @DianaLease @Michael-Grover |
I wonder if this is a bug or a feature. As we can see in the source code there is an explicit if condition to show the model when the cursor is inside the link. web-components/packages/ui-markdown-editor/src/index.js Lines 146 to 148 in 90973d4
If we let the cursor move forward in the link body, I believe they can also change the text and it will lead to a change in the name of the link. As I can see, the maintainers wanted to only have a single source of changing the link i.e LinkModal. |
@jeromesimeon I see that you made the change that introduced web-components/packages/ui-markdown-editor/src/index.js Lines 146 to 148 in 90973d4
Do you recall why you wanted this behaviour, please? |
Bug Report 馃悰
When we move our cursor forward in a line with the right arrow where one of the words is a hyperlink, the link popup opens up and the cursor jumps to the link URL input field.
Expected Behavior
The pop-up should not open up until we click on the hyperlink text. The cursor should move past the letters in the text one by one without the pop-up opening.
Current Behavior
It jumps to the URL input field as soon as the cursor touches the hyperlink text.
![CzyPqxr24S](https://user-images.githubusercontent.com/59534570/110848464-22980d80-82d4-11eb-80f3-4caf43accc6d.gif)
Steps to Reproduce
Context (Environment)
Desktop
Detailed Description
Possible Implementation
The text was updated successfully, but these errors were encountered: