MG-1965 - Process Event Logs #2057
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmuchyri
requested changes
Jan 14, 2024
rodneyosodo
force-pushed
the
events-svc
branch
from
4282f24
to
ed03818
Compare
ianmuchyri
requested changes
Jan 15, 2024
10 tasks
rodneyosodo
force-pushed
the
events-svc
branch
3 times, most recently
from
b877d43
to
26ef76a
Compare
rodneyosodo
force-pushed
the
events-svc
branch
6 times, most recently
from
ec76941
to
35c5eb1
Compare
rodneyosodo
force-pushed
the
events-svc
branch
2 times, most recently
from
449f7ac
to
a817162
Compare
rodneyosodo
force-pushed
the
events-svc
branch
6 times, most recently
from
74d1aa5
to
c993b35
Compare
rodneyosodo
force-pushed
the
events-svc
branch
3 times, most recently
from
7c42d98
to
3ac623d
Compare
rodneyosodo
force-pushed
the
events-svc
branch
5 times, most recently
from
3283210
to
1cab6c0
Compare
rodneyosodo
force-pushed
the
events-svc
branch
6 times, most recently
from
c65d282
to
3eb772c
Compare
arvindh123
reviewed
Jun 13, 2024
arvindh123
requested changes
Jun 13, 2024
activitylog/activity.go
Outdated
| case ThingEntity: | ||
| return "((operation LIKE 'thing.%' AND attributes->>'id' = :entity_id) OR (attributes->>'thing_id' = :entity_id))" | ||
| case ChannelEntity: | ||
| return "((operation LIKE 'channel.%' AND attributes->>'id' = :entity_id) OR (attributes->>'group_id' = :entity_id))" |
There was a problem hiding this comment.
@rodneyosodo
I could not list channelscreate event.
I think this should be group or we should change in all events to channel
arvindh123
requested changes
Jun 13, 2024
arvindh123
requested changes
Jun 13, 2024
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
- Added attributes and metadata as seperate values of activity. Metadata is normal metadata for an entity while attributes are the other entities from the event for example id, updated_at e.t.c - add entityType which can either be empty or user, group, thing or channel - add query method which generates SQL query depending on the entity type for example is the entity is user we retrieve entities that have id as the entity id and have operation that is prefixed with user. OR events that have user_id as an attribute correcsponding to that entity - update emission and consumption of events. Emit native types for example string slice for tags rather than formating it and also metadata as it is rather than marshalling it first into bytes This contains breaking changes on how events are consumed Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
A normal user can be able to list invitations but they will get only the operation and time it occurred unless you are the platform admin where you can view anything Signed-off-by: Rodney Osodo <[email protected]> Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Signed-off-by: Rodney Osodo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature PR because it adds eventlogs service to store history of events
What does this do?
Adds event logs service
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, I have included tests for my changes.
Did you document any new/modified feature?
Yes, I have updated the documentation for the new feature.
Notes